Skip to content

Add load type to snippet#615

Merged
silesky merged 2 commits intomasterfrom
add-load-type-to-snippet
Oct 6, 2022
Merged

Add load type to snippet#615
silesky merged 2 commits intomasterfrom
add-load-type-to-snippet

Conversation

@silesky
Copy link
Copy Markdown
Contributor

@silesky silesky commented Oct 6, 2022

Fixes #612
This is based on the work of @vai0 (thanks!) -- original PR is here: https://github.com/segmentio/analytics-next/pull/614/files

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 6, 2022

🦋 Changeset detected

Latest commit: a162271

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown

@jchi2241 jchi2241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@silesky silesky merged commit 6d51d38 into master Oct 6, 2022
@silesky silesky deleted the add-load-type-to-snippet branch October 6, 2022 18:14
@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type for AnalyticsSnippet is missing the load function

2 participants