Merged
Conversation
🦋 Changeset detectedLatest commit: 5db6a3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
arielsilvestri
commented
Nov 21, 2022
| expect(track.context).toEqual({ opt1: true }) | ||
| }) | ||
|
|
||
| test('sets context correctly if property arg is undefined', () => { |
Contributor
Author
There was a problem hiding this comment.
The bug didn't make it this far per se, but I wanted to harden this test suite again as it was a possible pain point.
arielsilvestri
commented
Nov 21, 2022
|
|
||
| let opts: Options = {} | ||
| if (isPlainObject(properties) && !isFunction(options)) { | ||
| if (!isFunction(options)) { |
Contributor
Author
There was a problem hiding this comment.
Originally had isPlainObject(data) here as well but data will always be an object at this point so it felt unnecessary here.
Contributor
|
Tested, this appears to work! Less complicated than I expected! Thanks! |
silesky
approved these changes
Nov 21, 2022
silesky
requested changes
Nov 21, 2022
silesky
approved these changes
Nov 21, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #649, there was a gap in the
resolveArgumentslogic that wouldn't letoptionsbe set ifpropertieswereundefined, as the original logic did not account for the case wherepropertieswouldn't be defined.