Conversation
🦋 Changeset detectedLatest commit: 9399b31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks good. Seems like the event emitter was kind of an afterthought, when it really can be exceptionally useful (I don't even know fits documented in the browser?) -- in node, the contract is very well defined and fully typed and every event gets emitted on by default with the context as an argument: ^ creating an enhanced dispatch feels cleaner, so we would just automatically emit on every type of event. We might be able to just port that function wholesale. |
|
Yeah, agreed. The browser version emits separately in each of the |
resetevent when user callsanalytics.reset(). This allows for external code to hook into the reset events and do further logic.yarn changeset. Read about changesets here).