Conversation
🦋 Changeset detectedLatest commit: fa3b354 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0e466fb to
06b962d
Compare
silesky
previously approved these changes
Jan 26, 2023
silesky
reviewed
Jan 26, 2023
|
|
||
| async queryString(query: string): Promise<Context[]> { | ||
| async queryString(query: string): Promise<Context[] | void> { | ||
| if (this.options.useQueryString === false) { |
Contributor
There was a problem hiding this comment.
Nitpick: should we return empty array instead to preserve the function signature?
Since .queryString is a public API and the function signature changed, this could be considered 'in theory' a breaking change. It would mostly affect existing typescript users who would need to update their code to handle the void case.
Contributor
Author
There was a problem hiding this comment.
Good catch! Let me fix that
realized had a potentially blocking question
silesky
approved these changes
Jan 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #769
New API to control the query param behaviour: