Fix ID Validation Error Message / refactor#835
Merged
Conversation
🦋 Changeset detectedLatest commit: 42ed459 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
changed the title
Contributor
Author
|
Fixes #834 |
silesky
changed the title
pooyaj
approved these changes
Apr 11, 2023
Contributor
pooyaj
left a comment
pooyaj
left a comment
There was a problem hiding this comment.
Looks great! love the bundle size savings 📉
Merged
nguyenlephong
pushed a commit
to nguyenlephong/analytics-next
that referenced
this pull request
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not have any behavior change.
I'm keeping the string requirement to be consistent with mobile SDK: I think it's better to force users to coerce IDs to string on their end, rather than have them surprised when their IDs are coerced for them. However, it's important to improve the error message.
Anyone upgrading from analytics-node who is now facing more strict ID validation will continue to get a validation error, but that error won't be misleading.
https://segment.atlassian.net/browse/LIBWEB-1377