Skip to content

Fix 'Promise is undefined' error that breaks ie11 auto-polyfill #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silesky merged 1 commit into from
Apr 20, 2023
Merged

Fix 'Promise is undefined' error that breaks ie11 auto-polyfill #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-spoons-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@segment/analytics-next': patch
---

Fix 'Promise is undefined' issue with ie11 polyfill
15 changes: 7 additions & 8 deletions packages/browser/src/browser/standalone.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,14 @@ import {

let ajsIdentifiedCSP = false

const sendErrorMetrics = (() => {
const sendErrorMetrics = (tags: string[]) => {
// this should not be instantied at the root, or it will break ie11.
const metrics = new RemoteMetrics()
return (tags: string[]) => {
metrics.increment('analytics_js.invoke.error', [
...tags,
`wk:${embeddedWriteKey()}`,
])
}
})()
metrics.increment('analytics_js.invoke.error', [
...tags,
`wk:${embeddedWriteKey()}`,
])
}

function onError(err?: unknown) {
console.error('[analytics.js]', 'Failed to load Analytics.js', err)
Expand Down
⚡