Skip to content

fix: support screen events on AJS on Segment Destination#896

Merged
oscb merged 1 commit intomasterfrom
oscb/screen
Jul 14, 2023
Merged

fix: support screen events on AJS on Segment Destination#896
oscb merged 1 commit intomasterfrom
oscb/screen

Conversation

@oscb
Copy link
Copy Markdown
Contributor

@oscb oscb commented Jul 13, 2023

Adds screen support to Segment's destination.

Previously screen events where captured and processed correctly but not sent to Segment.

Added tests.

[✔︎] I've included a changeset (psst. run yarn changeset. Read about changesets here).

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: 80c39ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@silesky silesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscb oscb merged commit 48ce3ec into master Jul 14, 2023
@oscb oscb deleted the oscb/screen branch July 14, 2023 16:56
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants