Collect timezone and allow userAgentData to be overridden#956
Merged
danieljackins merged 4 commits intomasterfrom Sep 26, 2023
Merged
Collect timezone and allow userAgentData to be overridden#956danieljackins merged 4 commits intomasterfrom
danieljackins merged 4 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: fedad18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@danieljackins CI is failing FYI |
chrisradek
reviewed
Sep 21, 2023
Comment on lines
+219
to
+220
| evtCtx.userAgentData = await clientHints( | ||
| this.instance.options.highEntropyValuesClientHints |
Contributor
There was a problem hiding this comment.
Similar to the original PR, can we cache the client hints during the plugin load? These fields won't change, so no reason to perform a potentially expensive operation on every event 😄
silesky
reviewed
Sep 21, 2023
|
|
||
| it('should add .timezone', async () => { | ||
| const ctx = await analytics.track('test') | ||
| assert(ctx.event.context?.timezone) |
Contributor
There was a problem hiding this comment.
can we assert that this is a string / actual TZ?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarn changeset. Read about changesets here).