feat: Add From Email to Personalization#1102
Merged
eshanholtz merged 3 commits intosendgrid:mainfrom Apr 13, 2021
Merged
Conversation
Add ability for Personalization to set the From Email address.
Add From Email to Personalization
thinkingserious
added
the
status: code review request
eshanholtz
approved these changes
Apr 13, 2021
Contributor
eshanholtz
left a comment
eshanholtz
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the contribution!
Contributor
Author
|
Thank you Elise for updating the solution. This will be very helpful for us.
Joseph
From: Elise Shanholtz ***@***.***>
Sent: Monday, April 12, 2021 5:09 PM
To: sendgrid/sendgrid-csharp ***@***.***>
Cc: Joseph Little ***@***.***>; Author ***@***.***>
Subject: Re: [sendgrid/sendgrid-csharp] feat: Add From Email to Personalization (#1102)
@eshanholtz approved this pull request.
Looks good! Thanks for the contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1102 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASAA42ASQG36U4NQ4CDFPN3TIODTPANCNFSM42VYTEOA>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add ability for Personalization to set the From Email address.
Note: The SendGrid API allows for the setting of the Personalization FromEmail and FromName but the sendgrid-csharp library does not. This small update allows these two fields to be set in the personalization.
Thank you!
Kind regards,
Joseph Little