Skip to content

Add a .env_sample file, update gitignore, update README.md#599

Merged
mbernier merged 4 commits intosendgrid:masterfrom
thepriefy:priefy-issue-597
Oct 30, 2017
Merged

Add a .env_sample file, update gitignore, update README.md#599
mbernier merged 4 commits intosendgrid:masterfrom
thepriefy:priefy-issue-597

Conversation

@thepriefy
Copy link
Copy Markdown
Contributor

@thepriefy thepriefy commented Oct 27, 2017

issue #597

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 27, 2017
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Oct 27, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mbernier
mbernier suggested changes Oct 29, 2017
View reviewed changes
README.md Outdated
### Initial Setup

```bash
cp .env_sample .env
Copy link
Copy Markdown
Contributor

@mbernier mbernier Oct 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be COPY as it is possible the user is in a windows terminal.

https://www.wikihow.com/Copy-Files-in-Command-Prompt

README.md Outdated
Update the development environment with your [SENDGRID_API_KEY](https://app.sendgrid.com/settings/api_keys), for example:

```bash
echo "export SENDGRID_API_KEY='YOUR_API_KEY'" > sendgrid.env
Copy link
Copy Markdown
Contributor

@mbernier mbernier Oct 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update for importing environment variables in windows?
https://stackoverflow.com/questions/185208/how-do-i-get-and-set-environment-variables-in-c

@mbernier
Copy link
Copy Markdown
Contributor

mbernier commented Oct 29, 2017

Two requests and if you can please sign the CLA, as well. Thank you @thepriefy - you've totally kicked ass this #hacktoberfest!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
mbernier
mbernier reviewed Oct 29, 2017
View reviewed changes
.env_sample Outdated
@@ -0,0 +1 @@
export SENDGRID_API_KEY='' No newline at end of file
Copy link
Copy Markdown
Contributor

@mbernier mbernier Oct 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove export, per sendgrid/smtpapi-php#58

@thepriefy
remove export
bec3e49
@thepriefy
update copy command
048beb0
@thepriefy
update README.md
edbf88f 
update how to set Environment variables in C#
@thepriefy
Copy link
Copy Markdown
Contributor Author

thepriefy commented Oct 29, 2017

@mbernier I've done editing but I'm not sure whether it is what you want or not. If you have any change you want or other suggestion, you can tell me and I'll fix it asap. :)

@mbernier
Copy link
Copy Markdown
Contributor

mbernier commented Oct 30, 2017

Well done!

@mbernier mbernier merged commit abd664e into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Oct 30, 2017

Hello @thepriefy,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thepriefy thepriefy deleted the priefy-issue-597 branch November 29, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mbernier mbernier mbernier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thepriefy @SendGridDX @mbernier @thinkingserious
⚡