fix: sendAt timestamp as 32bit integer#916
Merged
childish-sambino merged 2 commits intosendgrid:masterfrom Jun 23, 2020
Merged
Conversation
32bit signed integer will overflow in year 2038
thinkingserious
added
the
status: code review request
childish-sambino
approved these changes
Jun 23, 2020
Contributor
childish-sambino
left a comment
childish-sambino
left a comment
There was a problem hiding this comment.
@matrix0123456789 Change looks good to me. Could you tick the license acknowledgment in the PR summary so I can merge this?
childish-sambino
changed the title
Contributor
Author
|
Ok, ticked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
32bit signed integer will overflow in year 2038
Fixes
Checklist
Short description of what this PR does:
If you have questions, please send an email to Twilio Sendgrid, or file a Github Issue in this repository.