feat: sanity-check email address and address lists when adding to a message#981
Merged
childish-sambino merged 7 commits intosendgrid:masterfrom Feb 26, 2020
Merged
Conversation
Context: sendgrid#980 When sending an email and providing an empty list of BCCs the request fails with BadRequest as outlined here: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.bcc We want to inform the consumer that this is the case otherwise it may lead to email sending silenty failing.
thinkingserious
added
the
status: code review request
Contributor
Author
|
It looks like AddCC and other methods have the same issue, whilst I'm here I'll fix those too - hope that's okay? Indy |
Contributor
Author
|
Think I'm done :) Indy |
childish-sambino
changed the title
childish-sambino
changed the title
Contributor
|
Hello @indy-singh, |
Contributor
Author
|
Any idea when the updated package will be available in nuget?
*@childish-sambino*
…On Wed, 26 Feb 2020, 20:44 childish-sambino, ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#981?email_source=notifications&email_token=AAORQWWF3AIARNCM3AYNAXTRE3ICTA5CNFSM4K4MWULKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXCO6EA#pullrequestreview-365227792>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAORQWX5JC2JBBT2KGZZK6DRE3ICTANCNFSM4K4MWULA>
.
|
Contributor
|
Next scheduled release is for 2020-03-04. |
7 tasks
Contributor
Author
|
Is the updated sdk still being rolled out today?
…On Wed, 26 Feb 2020, 21:24 childish-sambino, ***@***.***> wrote:
Next scheduled release is for 2020-03-04.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#981?email_source=notifications&email_token=AAORQWTDPN5CCAXWIJJIYBLRE3MZHA5CNFSM4K4MWULKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENB6FFQ#issuecomment-591651478>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAORQWQLPCXGETMQWXY7RO3RE3MZHANCNFSM4K4MWULA>
.
|
Contributor
|
Yup, noon-ish pacific time typically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #980
When sending an email and providing an empty list of BCCs the request fails with BadRequest as outlined here: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.bcc
We want to inform the consumer that this is the case otherwise it may lead to email sending silenty failing.
Fixes
Checklist
Short description of what this PR does:
Pre send email validation to enforce the rules found here: https://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.bcc