Skip to content

Digest is allowed arbitrary DigestItem::PreRuntime #779

@kayabaNerve

Description

@kayabaNerve

frame-executive spawns the runtime with only the PreRuntime digests: https://github.com/serai-dex/patch-polkadot-sdk/blob/d9f7af4fa01866f5f7a4e6b07321e87f09e45c0c/polkadot-sdk/substrate/frame/executive/src/lib.rs#L597-L625

Nothing within Serai appears to limit what these PreRuntime digests are. In comparison, sc-consensus-babe has an error for when there are multiple BABE DigestItem::PreRuntime(_).

Serai needs to limit DigestItem::PreRuntime to its own and BABE and ensure only a single of each is allowed to prevent malicious block proposers from spamming blocks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingnode

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions