Coordinator QUIC#446
Open
kayabaNerve wants to merge 4 commits intodevelopfrom
Open
Conversation
kayabaNerve
force-pushed
the
coordinator-quic
branch
from
9554b93 to
2db7f19
Compare
kayabaNerve
force-pushed
the
coordinator-quic
branch
from
2db7f19 to
8d54419
Compare
Member
Author
|
Hm. It seems peers fail to discover each other over mdns when solely listening on QUIC... |
Also adds commented with_quic_config.
Member
Author
|
This works but we can't set a quic config unless we use libp2p 0.54, when polkadot-sdk hasn't merged 0.53 and will use a variety of methods deprecated 0.53 and removed in 0.54. Accordingly, I'm unsure 0.54 will be merged for a few months... |
Member
Author
|
I tried to apply this on the next branch. It's blocked by libp2p/rust-libp2p#5818 :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't justify this at this time. There's a complete lack of benchmarking, the QUIC feature is far less mature, and it grows the coordinator's tree by 30 crates.
I do, however, want to run the full CI on this and start tracking this as a potential future improvement.