fix: truncated name prevents details loading#22
Closed
athamala wants to merge 1 commit intoshanselman:mainfrom
Closed
fix: truncated name prevents details loading#22athamala wants to merge 1 commit intoshanselman:mainfrom
athamala wants to merge 1 commit intoshanselman:mainfrom
Conversation
athamala
force-pushed
the
fix/only-name-truncated
branch
from
241e229 to
d0e20ef
Compare
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes package is_truncated() call to consider only package id truncation. If only name is truncated, it doesn't prevent loading details with
winget show --id <id> --exact.parse_table_with_truncated_ids test extended to cover this case.