Add aarch64 Windows to CI.#1716
Conversation
|
Something I wanted to ask about (unfortunately GitHub doesn't let you leave comments on unchanged lines) - name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
targets: ${{ matrix.job.target }}
# On windows, for now build with 1.77.2, so that it works on windows 7.
# When we update the MSRV again, we'll need to revisit this, and probably drop support for Win7
toolchain: "${{ contains(matrix.job.target, 'windows-') && '1.77.2' || 'stable' }}"Given how new 64-bit ARM Windows is, and that Windows 7 for ARM does not exist, are you still going to use the older 1.77.2 toolchain for aarch64 Windows builds? |
|
Would it be better to wait until windows-11-arm is out of public preview for this? Or at least not fail the build if this fails until then? I would be fine with using a more recent rust for aarch64 windows. |
I personally think it valuable to have easy access to ARM builds for Windows fd users. As for the image's preview status, while its construction quality is definitely... interesting, the Rust tooling is reasonably mature as far as I can tell.
@sharkdp your thoughts? |
Closes #1658.
I tested the CI run in my fork; you can see the results here https://github.com/jcotton42/fd/actions/runs/14741919681.
I do not have an ARM Windows device to test with at the moment, but CI was successful, and a check with
filefrom Git Bash shows the binary is arm64.