Changes to support building/testing fd on Illumos#1742
Merged
tmccombs merged 4 commits intosharkdp:masterfrom Jun 23, 2025
Merged
Changes to support building/testing fd on Illumos#1742tmccombs merged 4 commits intosharkdp:masterfrom
tmccombs merged 4 commits intosharkdp:masterfrom
Conversation
Fix for sharkdp#1741: jemalloc doesn't build on Illumos, so add it to the list of excluded platforms.
nealsid
force-pushed
the
remove-illumos-jemalloc
branch
2 times, most recently
from
b79d928 to
8e9eb7e
Compare
nealsid
changed the title
tmccombs
reviewed
Jun 22, 2025
tmccombs
approved these changes
Jun 22, 2025
echo -n is not POSIX compliant, and this came up while running tests on Illumos.
rmdir on illumos does not support removing the current working directory, so this test errors out with EINVAL when calling std::fs::remove_dir.
nealsid
force-pushed
the
remove-illumos-jemalloc
branch
2 times, most recently
from
d69a759 to
654763d
Compare
Contributor
Author
|
@tmccombs ready to review/merge, thanks! |
tavianator
reviewed
Jun 23, 2025
| te.assert_output( | ||
| &[ | ||
| "foo", "--exec", "echo", "-n", "{/}: ", ";", "--exec", "echo", "{//}", | ||
| "foo", "--exec", "printf", "{/}: ", ";", "--exec", "echo", "{//}", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "foo", "--exec", "printf", "{/}: ", ";", "--exec", "echo", "{//}", | |
| "foo", "--exec", "printf", "%s", "{/}: ", ";", "--exec", "printf", "%s\\n", "{//}", |
nealsid
force-pushed
the
remove-illumos-jemalloc
branch
from
654763d to
e76e7ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1741: jemalloc doesn't build on Illumos, so add it to the list of excluded platforms.