feat(output): replace call of 'ls' with own detailled listing#1847
feat(output): replace call of 'ls' with own detailled listing#1847defigli wants to merge 4 commits intosharkdp:masterfrom
Conversation
| .duration_since(SystemTime::UNIX_EPOCH) | ||
| .unwrap_or(std::time::Duration::ZERO); | ||
| let timestamp = | ||
| Timestamp::new(duration.as_secs() as i64, duration.subsec_nanos() as i32).unwrap(); |
2ceb725 to
9b4e9b4
Compare
tmccombs
left a comment
There was a problem hiding this comment.
Builds are failing. Please make sure this compiles, tests pass, and the feature actually works before making a PR.
I haven't reviewed this thoroughly, but I suspect that it was generated with AI. If that was the case, please indicate it, and review it yourself to ensure it is high quality.
| fn extract_command(opts: &mut Opts) -> Result<Option<CommandSet>> { | ||
| opts.exec.command.take().map(Ok).transpose() | ||
| ignore_contain: opts.ignore_contain, |
There was a problem hiding this comment.
I'm not sure what happened here, but this isn't valid syntax, and is probably part of why the builds are failing.
| crossbeam-channel = "0.5.15" | ||
| clap_complete = {version = "4.6.0", optional = true} | ||
| faccess = "0.2.4" | ||
| jiff = "0.2.14" |
There was a problem hiding this comment.
we already have a dependency on jiff, why are you adding it again?
There was a problem hiding this comment.
Is there any overlap between these changes and #1866? Could we avoid duplicating logic for getting the additional information.
Closes #1845
The call of
ls -lhdis replaced by a native detailled listing.Sample output: