Change --exclude value name from 'pattern' to 'glob'#1921
Merged
tmccombs merged 1 commit intosharkdp:masterfrom Mar 17, 2026
Merged
Change --exclude value name from 'pattern' to 'glob'#1921tmccombs merged 1 commit intosharkdp:masterfrom
tmccombs merged 1 commit intosharkdp:masterfrom
Conversation
The summary line `-E, --exclude <pattern>` is misleading because fd defaults to regex for its main search pattern, but --exclude takes a glob. Rename the value placeholder to "glob" in the CLI help, man page, and README to match the actual behavior. Fixes sharkdp#1724 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tmccombs
approved these changes
Mar 17, 2026
Collaborator
tmccombs
left a comment
tmccombs
left a comment
There was a problem hiding this comment.
It isn't completely accurate, because it is actually a gitignore rule, which supports more syntax than just a glob, but it's close enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1724
The summary line
-E, --exclude <pattern>is misleading because fd defaults to regex for its main search pattern, but--excludetakes a glob. Users naturally assume--excludealso takes regex.Changed the value placeholder from
patterntoglobin:value_namein clap)doc/fd.1)Test plan