fix: always error on patterns containing path separators#1930
Closed
qianchongyang wants to merge 1 commit intosharkdp:masterfrom
Closed
fix: always error on patterns containing path separators#1930qianchongyang wants to merge 1 commit intosharkdp:masterfrom
qianchongyang wants to merge 1 commit intosharkdp:masterfrom
Conversation
…stence Previously, the error about '/' in pattern was only shown when the pattern was also an existing directory. Now it shows consistently regardless of whether the path exists. Fixes sharkdp#1873
Collaborator
|
This doesn't address #1873 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fdonly shows the "pattern contains path separator" error when the pattern also happens to be an existing directory. In all other cases it silently returns no results, which is inconsistent and confusing.Solution
Remove the directory existence check so any pattern containing a path separator triggers the same guidance unless
--full-pathis used.Validation
src/main.rscargo build/testcould not be run on the Oracle host because the Rust toolchain is not installed thereFixes #1873