fix: show path separator error for all patterns with separators#1942
Closed
cyphercodes wants to merge 1 commit intosharkdp:masterfrom
Closed
fix: show path separator error for all patterns with separators#1942cyphercodes wants to merge 1 commit intosharkdp:masterfrom
cyphercodes wants to merge 1 commit intosharkdp:masterfrom
Conversation
The 'pattern contains path separator' error was only shown when the pattern was an existing directory. This caused inconsistent behavior where 'fd /' showed an error but 'fd /nonexistent/path' silently found nothing. This fix removes the Path::is_dir() check so the error is shown consistently whenever a pattern contains a path separator, improving user experience with clear feedback. Fixes sharkdp#1873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'pattern contains path separator' error was only shown when the pattern was an existing directory. This caused inconsistent behavior where 'fd /' showed an error but 'fd /nonexistent/path' silently found nothing.
This fix removes the Path::is_dir() check so the error is shown consistently whenever a pattern contains a path separator, improving user experience with clear feedback.
Fixes #1873