Skip to content

Fix fdfind bash completion symlink in Debian packages#1970

Closed
lawrence3699 wants to merge 1 commit intosharkdp:masterfrom
lawrence3699:fix/fdfind-bash-completion
Closed

Fix fdfind bash completion symlink in Debian packages#1970
lawrence3699 wants to merge 1 commit intosharkdp:masterfrom
lawrence3699:fix/fdfind-bash-completion

Conversation

@lawrence3699
Copy link
Copy Markdown

Fixes #1888.

Before this change, scripts/create-deb.sh installed the bash completion file as usr/share/bash-completion/completions/fd but created the fdfind symlink as ./fd.bash, which leaves a dangling symlink in the Debian package.

This updates the bash completion symlink to ./fd, matching the installed file name. The fish and zsh fdfind symlinks already point to their installed completion file names, so this makes the bash packaging consistent with the sibling paths.

Validation:

  • bash -n scripts/create-deb.sh
  • git diff --check
  • local packaging-layout fixture confirming fdfind -> ./fd resolves alongside the existing fish and zsh completion symlinks

Copilot AI review requested due to automatic review settings April 17, 2026 00:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a Debian packaging issue where the fdfind bash-completion symlink was created with a dangling target, preventing completions from working for the fdfind alias.

Changes:

  • Update scripts/create-deb.sh to symlink fdfind bash completion to ./fd (matching the installed completion filename).
  • Add a corresponding entry to the Unreleased bugfixes section in CHANGELOG.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/create-deb.sh Fixes the fdfind bash-completion symlink target to match the installed fd completion file name.
CHANGELOG.md Documents the Debian fdfind bash-completion symlink fix under Unreleased bugfixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tmccombs
Copy link
Copy Markdown
Collaborator

This was fixed by #1889

@tmccombs tmccombs closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Bash completions do not work for alias fdfind in deb release

3 participants