Change has_color_for to public visibility#92
Merged
sharkdp merged 2 commits intosharkdp:masterfrom Oct 19, 2025
Merged
Conversation
tavianator
reviewed
Sep 14, 2025
bkueng
force-pushed
the
pub_has_color_for
branch
from
17c5573 to
4c1c83f
Compare
…xplicit_syle_for coreutils (https://github.com/uutils/coreutils) uses style_for_indicator to check if a style for Indicator::Capabilities is available. However, style_for_indicator uses fallbacks and can therefore return a style even if no direct style for Indicator::Capabilities is set. Directly being able to use has_color_for allows to fix that.
sharkdp
force-pushed
the
pub_has_color_for
branch
from
4c1c83f to
51d1834
Compare
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coreutils uses
style_for_indicatorto check if a style forIndicator::Capabilitiesis available. However,style_for_indicatoruses fallbacks and can therefore return a style even if no direct style forIndicator::Capabilitiesis set.Directly being able to use
has_color_forallows to fix that.