Fix: resolve false positives for BoardGameGeek detection#2837
Open
UmmuWambai wants to merge 1 commit intosherlock-project:masterfrom
Open
Fix: resolve false positives for BoardGameGeek detection#2837UmmuWambai wants to merge 1 commit intosherlock-project:masterfrom
UmmuWambai wants to merge 1 commit intosherlock-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoardGameGeek detection was producing false positives due to ambiguous responses from the username validation API.
Resolves #2803
The endpoint returns:
Previously, only one condition was checked, causing invalid usernames to be incorrectly marked as existing users.
This change updates detection to handle both "not found" cases:
This ensures:
Tested with: