Skip to content

Fix: resolve false positives for BoardGameGeek detection#2837

Open
UmmuWambai wants to merge 1 commit intosherlock-project:masterfrom
UmmuWambai:fix-boardgamegeek-false-positives
Open

Fix: resolve false positives for BoardGameGeek detection#2837
UmmuWambai wants to merge 1 commit intosherlock-project:masterfrom
UmmuWambai:fix-boardgamegeek-false-positives

Conversation

@UmmuWambai
Copy link
Copy Markdown

@UmmuWambai UmmuWambai commented Mar 25, 2026

BoardGameGeek detection was producing false positives due to ambiguous responses from the username validation API.

Resolves #2803

The endpoint returns:

  • "isValid": true → username available (user does not exist)
  • "isValid": false → either username already exists OR username is invalid

Previously, only one condition was checked, causing invalid usernames to be incorrectly marked as existing users.

This change updates detection to handle both "not found" cases:

  • available usernames ("isValid": true)
  • invalid usernames (validation error message)

This ensures:

  • existing users are correctly detected
  • non-existent and invalid usernames are not falsely marked as found

Tested with:

  • existing username
  • valid non-existing username
  • invalid username

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False negative for: BoardGameGeek

1 participant