fix(data): resolve Shelf false negative#2845
Open
juliosuas wants to merge 12 commits intosherlock-project:masterfrom
Open
fix(data): resolve Shelf false negative#2845juliosuas wants to merge 12 commits intosherlock-project:masterfrom
juliosuas wants to merge 12 commits intosherlock-project:masterfrom
Conversation
GNOME VCS (sherlock-project#2804): Switch from response_url to API-based detection using /api/v4/users?username={} endpoint (same approach as GitLab). The previous response_url method failed because non-existent users get 302-redirected to /users/sign_in instead of staying at the profile URL. Patched (sherlock-project#2805): Update domain from patched.sh to patched.to. The site migrated domains, causing all lookups to fail with the old URL. Verified both fixes: GNOME VCS API returns user data for existing users and [] for non-existent ones. Patched.to returns the expected error message for invalid users on the new domain. Fixes sherlock-project#2804 Fixes sherlock-project#2805
Patched.sh now redirects to patched.to, which returns HTTP 403 for all requests (both existing and non-existing users) due to Cloudflare WAF. This causes guaranteed false positives. GNOME VCS fix (API-based detection) is retained and passes F+/F- validation locally.
shelf.im migrated to a SvelteKit SPA that returns HTTP 200 for all profile URLs. Non-existent users render 'User Not Found' in the page body instead of a different status code. Switch detection from status_code to message-based with errorMsg 'User Not Found'. Verified F+ and F- locally.
Contributor
Automatic validation of changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2806 — Shelf produces false negatives for all usernames.
Root Cause
shelf.immigrated to a SvelteKit SPA that returns HTTP 200 for all profile URLs, including non-existent users. The previousstatus_codedetection always saw 200, so it marked every username as "Claimed" (or never found them, depending on flow).Non-existent users render
User Not Foundin the page body.Fix
Switch detection method from
status_codetomessagewith:errorMsg:"User Not Found"errorType:"message"Verification
bluexyzNonexistent123456789