fix: upgrade site URLs from HTTP to HTTPS#2850
Open
JasonOA888 wants to merge 2 commits intosherlock-project:masterfrom
Open
fix: upgrade site URLs from HTTP to HTTPS#2850JasonOA888 wants to merge 2 commits intosherlock-project:masterfrom
JasonOA888 wants to merge 2 commits intosherlock-project:masterfrom
Conversation
All 5 sites (Gravatar, PromoDJ, Wikidot, authorSTREAM, datingRU) confirmed to support HTTPS. Using plain HTTP leaks query data and is vulnerable to MITM attacks. Verified HTTPS support for each site before updating.
Contributor
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
Gravatar's en.gravatar.com redirects to gravatar.com which returns 404 for all users - detection is broken regardless of protocol. Keep HTTP to avoid changing a broken target. authorSTREAM failed F- check on HTTPS - reverting until investigated.
Contributor
Automatic validation of changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades 5 site configurations from plain HTTP to HTTPS.
All 5 sites confirmed to support HTTPS:
Using plain HTTP leaks username queries on the wire and is vulnerable to MITM attacks. Two additional sites (igromania, uid.me) were left unchanged as their HTTPS endpoints were unreachable.