Skip to content

fix: resolve false positives for ArtStation, BoardGameGeek, and Envato Forum#2856

Open
aashish-thapa wants to merge 1 commit intosherlock-project:masterfrom
aashish-thapa:fix/false-positives-long-usernames
Open

fix: resolve false positives for ArtStation, BoardGameGeek, and Envato Forum#2856
aashish-thapa wants to merge 1 commit intosherlock-project:masterfrom
aashish-thapa:fix/false-positives-long-usernames

Conversation

@aashish-thapa
Copy link
Copy Markdown

  • Remove ArtStation and Envato Forum: both are SPAs that return HTTP 200 for all usernames, making detection impossible.
  • Fix BoardGameGeek: add username length validation error to errorMsg so long usernames are correctly marked as available.

Partially addresses #2313

…o Forum

- Remove ArtStation: SPA returns HTTP 200 with empty body for all
  usernames, making status_code detection impossible.
- Remove Envato Forum: same issue as ArtStation — SPA always returns 200.
- Fix BoardGameGeek: add username length validation error to errorMsg
  list so long usernames (>20 chars) are correctly marked as available
  instead of falsely claimed.

Partially addresses sherlock-project#2313
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Automatic validation of changes

Target F+ Check F- Check
BoardGameGeek ❌   Fail ✔️   Pass

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant