feat: add --check-sites command for batch site validation#2859
Open
mvanhorn wants to merge 1 commit intosherlock-project:masterfrom
Open
feat: add --check-sites command for batch site validation#2859mvanhorn wants to merge 1 commit intosherlock-project:masterfrom
mvanhorn wants to merge 1 commit intosherlock-project:masterfrom
Conversation
Adds a --check-sites flag that validates every site in data.json by testing each site's username_claimed value against the existing detection logic. Reports broken, timed out, and healthy sites. This helps maintainers proactively identify broken sites instead of relying on individual user reports for false positives/negatives. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--check-sitesflag that batch-validates every site in data.json by testing each site'susername_claimedvalue against the existing detection logic. Reports broken, timed out, and healthy sites with a summary table.Why this matters
Sites break constantly: domains expire, WAFs change, pages restructure. Right now there's no way to proactively check which sites are still working. Maintainers rely on individual user reports.
Six open FP/FN reports in recent months. A batch validation command catches these proactively.
Changes
check_sites()function insherlock.pythat iterates over all sites, runs the existingsherlock()detection on each site'susername_claimeduser, and classifies results as OK/BROKEN/TIMEOUT--check-sitesargparse flag. Changedusernamepositional tonargs="*"with a custom validation that requires either usernames or--check-sitesQueryNotifyclass (silent) to suppress per-site output during health checkstest_ux.pyto match the newnargs="*"behavior for the unrecognized-argument edge caseDemo
Testing
--check-sites --site GitHub --site Reddit --site Twitter --timeout 15shows clean outputThe
check_sites()function reuses the existingsherlock()function andSherlockFuturesSessionfor parallel requests, so it runs against the same detection logic users already rely on.This contribution was developed with AI assistance (Claude Code).