Skip to content

fix: detect 1337x invalid username response#2861

Open
kuishou68 wants to merge 1 commit intosherlock-project:masterfrom
kuishou68:fix/2815-1337x-false-positive
Open

fix: detect 1337x invalid username response#2861
kuishou68 wants to merge 1 commit intosherlock-project:masterfrom
kuishou68:fix/2815-1337x-false-positive

Conversation

@kuishou68
Copy link
Copy Markdown

@kuishou68 kuishou68 commented Apr 3, 2026

Summary

  • add the invalid username HTML snippet reported in issue 2815 to the 1337x site definition
  • include both the capital-U and lowercase-u Bad username variants to avoid a fragile case-sensitive miss
  • keep the change limited to site data so behavior for other providers stays untouched

Self-review

  • re-checked the issue report before changing anything to confirm this is a site-data mismatch, not a core matcher bug
  • kept the fix in the site data file instead of changing matching logic, because the failure is specific to 1337x response content
  • validated the edited JSON parses cleanly after the change

Closes #2815

@kuishou68 kuishou68 mentioned this pull request Apr 3, 2026
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Automatic validation of changes

Target F+ Check F- Check
1337x ❌   Fail ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for: 1337x.to

1 participant