Skip to content

Add low accuracy sin, cos, log2, exp2 and pow#229

Merged
shibatch merged 9 commits intomasterfrom
Add_lowprec_sin_cos
Mar 12, 2019
Merged

Add low accuracy sin, cos, log2, exp2 and pow#229
shibatch merged 9 commits intomasterfrom
Add_lowprec_sin_cos

Conversation

@shibatch
Copy link
Copy Markdown
Owner

I added the following functions.

  • fastsinf_u3500
  • fastcosf_u3500
  • fastpowf_u3500
  • log2_u35, log2f_u35
  • exp2_u35, exp2f_u35

The error bound of fastsin and fastcos are max(2e-6, 350ULPs).
Each function has corresponding deterministic functions.

@xoofx Please let me know how you think about these functions.

@shibatch shibatch requested review from fpetrogalli and xoofx October 28, 2018 09:44
@xoofx
Copy link
Copy Markdown
Collaborator

xoofx commented Oct 28, 2018

Amazing, will have a look, thanks!

@shibatch
Copy link
Copy Markdown
Owner Author

Testing at Travis is failing because brew is trying to build gcc from its source code.

@fpetrogalli
Copy link
Copy Markdown

Why introduce the fast prefix in the names?

@shibatch
Copy link
Copy Markdown
Owner Author

shibatch commented Nov 1, 2018

Because the error bound is not only specified by ULP value.
The fast trig functions sometimes returns values higher than 1.
The pow function tends to underflow easily.
So, they are pretty sloppy functions.

@fpetrogalli
Copy link
Copy Markdown

Testing at Travis is failing because brew is trying to build gcc from its source code.

Is this something that is broken also on master? If so, I think we should fix master first...

@shibatch
Copy link
Copy Markdown
Owner Author

shibatch commented Nov 3, 2018

I am hoping that this "problem" will be fixed at brew side.
Otherwise, we need to change the CI setting, of course.

@shibatch shibatch mentioned this pull request Dec 3, 2018
@shibatch shibatch merged commit a77ba9e into master Mar 12, 2019
@shibatch shibatch deleted the Add_lowprec_sin_cos branch March 12, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants