Add low accuracy sin, cos, log2, exp2 and pow#229
Merged
Conversation
Collaborator
|
Amazing, will have a look, thanks! |
Owner
Author
|
Testing at Travis is failing because brew is trying to build gcc from its source code. |
|
Why introduce the |
Owner
Author
|
Because the error bound is not only specified by ULP value. |
Is this something that is broken also on master? If so, I think we should fix master first... |
Owner
Author
|
I am hoping that this "problem" will be fixed at brew side. |
Closed
xoofx
approved these changes
Mar 6, 2019
fpetrogalli
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the following functions.
The error bound of fastsin and fastcos are max(2e-6, 350ULPs).
Each function has corresponding deterministic functions.
@xoofx Please let me know how you think about these functions.