Fix compilation under Windows with MinGW#266
Fix compilation under Windows with MinGW#266shibatch merged 2 commits intoshibatch:masterfrom Eroware:master
Conversation
|
What's wrong with the Jenkins? The first commit with |
|
@nxrighthere Thank you for your commit! |
|
I'm not sure what's the correct condition but this breaks my compilation under msys2 using |
|
On which OS? |
|
Windows 10 |
|
This was the The |
|
I think the condition should be then |
|
That should cover my case for sure. However, I don't really use windows (edit: and the PKGBUILD above was for my lab...) and have no idea what's the difference between all these posix like environment for windows so I can't say what should be the correct logic ...... = = .... |
|
If you use the standalone MinGW then |
|
Sounds fair. What I mainly don't understand is why does |
|
Good question, I'm not using MSYS2, so can't explain where the problem is. |
|
In particular, for me, the I just tried using the |
|
One solution could be to build a command for displaying the content of a file from a source code. |
Similar to 75b62aa (shibatch#396) for better support of MinGW. This fixes the regression caused by shibatch#266 when building for mingw under msys2.
The compiler-specific condition for
typeandcatis incorrect. Also<io.h>is missed for_get_osfhandle.