Conversation
|
The cross-compilation test is not passing. https://shibatch.dns-cloud.net/jenkins8086/job/sleef/job/PR-629/1/consoleFull |
|
@shibatch I am not sure why this happened because when I tried in PPC Linux with the same commands as in the Jenkins build, it worked. I have made a guess looking at the library name that it might have to do something with the change in src/common/quaddef.h. Can we check again with the recent change I made? |
|
The culprit seems to be this?
Is VSX support removed in gcc-14? |
| #error \"Only VSX(ISA2.07) little-endian mode is supported \" | ||
| #if !defined(__LITTLE_ENDIAN__) && !defined(_AIX) | ||
| #error \"Only VSX(ISA2.07) little-endian mode and AIX is supported \" | ||
| #endif |
There was a problem hiding this comment.
You don't need this #endif here.
There was a problem hiding this comment.
@shibatch I have corrected this. Thank you for pointing out.
|
@shibatch It is possible since I see In my PPC Linux LPAR. |
Closes shibatch#628.
|
I am sorry, but the AIX support will be removed before SLEEF 4.0 is released. You may think that the code for AIX support is minimal and untested, so the cost may seem low. Especially for IBM related architectures, there are already two, powerpc and S390X, and S390X is a big endian architecture, which is rare these days, so there is an extra maintenance cost. These architectures do not have a large market share, and we cannot accept additional cost increases on top of the maintenance costs we are currently paying for free. |
|
@shibatch I understand your concern. But we do need sleef to be working on AIX for PyTorch. Otherwise our customers and users will not be able to do AIX is putting an effort to modernize, and we are supported in CMake, ONNXRuntime, Scipy, Numpy, Pandas, Meson, and even in talks with the PyTorch community via PRs for AIX support. You can feel free to change anything you want to in the future in Sleef without worrying about AIX. We have CIs internally running and will make sure Sleef is working in AIX, and if something breaks, I will raise a PR to fix it. You can also connect with @ranjitshs, @ayappanec or me (@KamathForAIX) for any queries related to AIX. Having said that, is there anything we can do that would work for AIX and you that you have in mind? Kindly let me know. We are open to suggestions. |
|
At this time, the SLEEF project has no sponsor and is basically maintained entirely by myself. https://github.com/shibatch/nofreelunch?tab=coc-ov-file |
Closes #628.