Conversation
Convert DFT benchmarking utility to C++.
| @@ -0,0 +1,29 @@ | |||
| #if !(defined(__MINGW32__) || defined(__MINGW64__) || defined(_MSC_VER)) | |||
There was a problem hiding this comment.
Why not using _WIN32, which is the macro to identify a Windows target, instead of listing different compilers?
There was a problem hiding this comment.
Is there a page that systematically explains which macros are defined when using each compiler on Windows? The page you provided is from Microsoft's website, and I don't think it provides reliable information about MinGW.
There was a problem hiding this comment.
MinGW does define _WIN32. Tat's the only macro required to be defined by a compiler targeting any Windows system.
There was a problem hiding this comment.
The problem with predefined macros is that there is often no proper documentation explaining their intended purpose. In this case, it is difficult to say that the current approach is wrong.
| static FILE *OPENTMPFILE() { return tmpfile(); } | ||
| static void CLOSETMPFILE(FILE *fp) { fclose(fp); } | ||
| #else | ||
| #include <Windows.h> |
There was a problem hiding this comment.
Please use lowercase header files, otherwise this breaks compilation on case-sensitive filesystems (e.g. when targeting MinGW on Linux).
There was a problem hiding this comment.
To be honest, it is difficult to support non-standard build methods such as building for MinGW on Linux. Instead, I would suggest that MinGW consider creating a symbolic link from Windows.h to windows.h.
There was a problem hiding this comment.
If the MinGW project adopts our Code of Conduct, I will upgrade MinGW to Tier 1 support.
There was a problem hiding this comment.
I'm truly delighted that you seem to be giving serious consideration.
You can understand the content of the CoC in just 30 minutes by watching this video, so please make use of it.
2 participants
This PR adds DFT planner testing.