Skip to content

store zero element as a map of elements for each separate body #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neryams wants to merge 3 commits into
base: master
Choose a base branch
from
Open

store zero element as a map of elements for each separate body #908

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af943d2
store zero element as a map of elements for each separate body
neryams Oct 5, 2021
2fee4c8
fix spacing
neryams Oct 5, 2021
ca2e905
add a unit test for calculating bounds
neryams Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/js/utils/bounds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { extend, uniqueId } from './general';
import { isUndefined } from './type-check';

const zeroPosCache = {};
let zeroElement = null;
const zeroElements = new Map();

export function getBounds(body, el) {
let doc;
Expand Down Expand Up @@ -143,10 +143,11 @@ export function getVisibleBounds(body, target) {
}

export function removeUtilElements(body) {
if (zeroElement) {
body.removeChild(zeroElement);
}
zeroElement = null;
if (zeroElements.has(body)) {
body.removeChild(zeroElements.get(body));
}

zeroElements.delete(body);
}

/**
Expand Down Expand Up @@ -187,7 +188,7 @@ function _getOrigin(body) {
// jitter as the user scrolls that messes with our ability to detect if two positions
// are equivilant or not. We place an element at the top left of the page that will
// get the same jitter, so we can cancel the two out.
let node = zeroElement;
let node = zeroElements.get(body);
if (!node || !body.contains(node)) {
node = document.createElement('div');
node.setAttribute('data-tether-id', uniqueId());
Expand All @@ -199,7 +200,7 @@ function _getOrigin(body) {

body.appendChild(node);

zeroElement = node;
zeroElements.set(body, node);
}

const id = node.getAttribute('data-tether-id');
Expand Down
⚡