Skip to content

Mixed visits when still loading previous page #301

@acelaya

Description

@acelaya

Shlink web client version

  • Version: All
  • How do you use shlink-web-client: All

Summary

When trying to load a big dataset of visits, the requests are done in blocks (4 at a time). If you leave the page while one of those blocks is loading and then come back for a different short URL or tag, the visits get mixed with those coming from the 4 requests that were still in progress.

A possible way to prevent this would be to properly cancel on-flight requests when leaving the visits page, which is not currently done.

Edit: It's only affecting visit stats, not short URL stats.

Current behavior

Visits getting loaded in the background get mixed with visits loaded for a new selection.

Expected behavior

Previous visits should be discarded, and only new ones should be displayed.

How to reproduce

Load a page with a lot of visits (ideally more than 25k). Before finishing loading, go back to the list of visits or tags, and select a different one.

The page will feel unresponsive for a few seconds and then you'll see some visits from previous request on current data set.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions