Support servers.json in a conf.d directory#432
Merged
Conversation
Preview environmenthttps://shlinkio.github.io/shlink-web-client/feature-conf-volume/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #432 +/- ##
==========================================
Coverage ? 75.62%
==========================================
Files ? 142
Lines ? 1670
Branches ? 242
==========================================
Hits ? 1263
Misses ? 213
Partials ? 194 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In Cattle (and maybe other Docker environments) you can't mount specific files, but have to mount a whole volume as a directory. We now allow the servers.json to be looked for inside a specific folder to support that use case.
… conflicting rule
acelaya
force-pushed
the
feature/conf-volume
branch
from
a0a64fc to
bbc3342
Compare
Member
|
Thanks! |
matiasgarciaisaia
added a commit
to matiasgarciaisaia/shlink-web-client
that referenced
this pull request
May 29, 2021
Alfar0nt
pushed a commit
to Alfar0nt/dhiarlink-web-client
that referenced
this pull request
Jun 15, 2026
…olume Support servers.json in a conf.d directory
Alfar0nt
pushed a commit
to Alfar0nt/dhiarlink-web-client
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Cattle (and maybe other Docker environments) you can't mount specific files, but have to mount a whole volume as a directory.
This PR allows the
servers.jsonto be looked for inside a specific folder to support that use case.Instead of running:
This PR allows to run:
With the same results.
The
conf.dmay become handy for other configuration files in the future (if there are any other ones).