[POC] Render QR codes client-side, using a library instead of Shlink's URL#637
Merged
Merged
Conversation
7448bc2 to
e62bdfd
Compare
e62bdfd to
5c0b2dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 79.27% 79.15% -0.13%
==========================================
Files 177 177
Lines 7842 7876 +34
Branches 1499 1489 -10
==========================================
+ Hits 6217 6234 +17
- Misses 162 190 +28
+ Partials 1463 1452 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26912d4 to
9de9ab7
Compare
Member
Author
|
The missing code coverage requires running tests in an actual browser to properly test it. This is being addressed separately. |
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept to provide a way to generate customized short URL QR codes, without depending on Shlink's
/{short-code}/qr-codepublic URL, which is a liability and getting deprecated, to eventually be removed in Shlink 5.0.0This aims to provide the same capabilities, but without having to hit Shlink's server at all, and with the eventual ability to locally store the default QR code configuration in the apps using
ShlinkWebComponent.client-side-qr-codes.mp4