[18.0] [FWPORT] [IMP] shopinvader_api_delivery_carrier: Add deliveries lines and search filter params#24
Merged
shopinvader-git-bot merged 4 commits intoMay 27, 2026
Conversation
The _onchange_carrier_id inside the wizard was only called for delivery types 'Fixed' and 'Base on rule'. But for some specific delivery methods, Odoo adds new delivery types (see delivery_ups_rest for eg). The _get_shipment_rate method is computing the delivery prices for all delivery carrier types
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 18.0 #24 +/- ##
==========================================
+ Coverage 96.54% 97.03% +0.48%
==========================================
Files 22 22
Lines 579 674 +95
Branches 21 27 +6
==========================================
+ Hits 559 654 +95
Misses 9 9
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastienbeau
approved these changes
May 27, 2026
sebastienbeau
left a comment
sebastienbeau
left a comment
Collaborator
There was a problem hiding this comment.
LGTM (same as V16)
/ocabot merge minor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at bc9bad7. Thanks a lot for contributing to shopinvader. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #14