Skip to content

[16.0] [ADD] shopinvader_api_mass_mailing#1648

Merged
shopinvader-git-bot merged 1 commit into
shopinvader:16.0from
akretion:16.0-add-shopinvader_api_mass_mailing
May 27, 2026
Merged

[16.0] [ADD] shopinvader_api_mass_mailing#1648
shopinvader-git-bot merged 1 commit into
shopinvader:16.0from
akretion:16.0-add-shopinvader_api_mass_mailing

Conversation

@paradoxxxzero

Copy link
Copy Markdown
Contributor

This module adds per endpoint configurable mailing list and two new public routes to
manage the subscription of a contact to the mailing list.

  • /shopinvader_api/mailing/subscribe to subscribe a contact to the mailing list
  • /shopinvader_api/mailing/unsubscribe to unsubscribe a contact from the mailing list

A contact here is defined by its email address, no partner is linked or created.

It may be intersting to protect these endpoints with a captcha to avoid abuse,
you could take a look at the fastapi_captcha for instance.

@codecov

codecov Bot commented Feb 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.09%. Comparing base (b39caed) to head (e8ea131).

Files with missing lines Patch % Lines
...nvader_api_mass_mailing/models/fastapi_endpoint.py 77.77% 2 Missing ⚠️
...opinvader_api_mass_mailing/routers/mass_mailing.py 95.12% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0    #1648      +/-   ##
==========================================
+ Coverage   95.06%   95.09%   +0.02%     
==========================================
  Files         484      494      +10     
  Lines       10040    10168     +128     
  Branches      509      513       +4     
==========================================
+ Hits         9545     9669     +124     
- Misses        351      354       +3     
- Partials      144      145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paradoxxxzero paradoxxxzero marked this pull request as ready for review May 20, 2026 08:25

@sebastienbeau sebastienbeau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (already merged in 18)

@sebastienbeau

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@shopinvader-git-bot

Copy link
Copy Markdown

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1648-by-sebastienbeau-bump-nobump, awaiting test results.

@shopinvader-git-bot

Copy link
Copy Markdown

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1648-by-sebastienbeau-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebastienbeau sebastienbeau force-pushed the 16.0-add-shopinvader_api_mass_mailing branch from 3ad2c38 to e8ea131 Compare May 27, 2026 13:34
@sebastienbeau

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@shopinvader-git-bot

Copy link
Copy Markdown

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1648-by-sebastienbeau-bump-nobump, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit adf593a into shopinvader:16.0 May 27, 2026
5 checks passed
@shopinvader-git-bot

Copy link
Copy Markdown

Congratulations, your PR was merged at fd34c42. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants