[16.0] [ADD] shopinvader_api_mass_mailing#1648
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 16.0 #1648 +/- ##
==========================================
+ Coverage 95.06% 95.09% +0.02%
==========================================
Files 484 494 +10
Lines 10040 10168 +128
Branches 509 513 +4
==========================================
+ Hits 9545 9669 +124
- Misses 351 354 +3
- Partials 144 145 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastienbeau
left a comment
There was a problem hiding this comment.
LGTM (already merged in 18)
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1648-by-sebastienbeau-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
3ad2c38 to
e8ea131
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at fd34c42. Thanks a lot for contributing to shopinvader. ❤️ |
This module adds per endpoint configurable mailing list and two new public routes to
manage the subscription of a contact to the mailing list.
/shopinvader_api/mailing/subscribeto subscribe a contact to the mailing list/shopinvader_api/mailing/unsubscribeto unsubscribe a contact from the mailing listA contact here is defined by its email address, no partner is linked or created.
It may be intersting to protect these endpoints with a captcha to avoid abuse,
you could take a look at the
fastapi_captchafor instance.