[bug]: interaction with nvim-dap-ui causes windows size problems

[franksl]

Description

Hi,
I have both no-neck-pain and nvim-dap-ui on my setup.
When activating/deactivating nvim-dap-ui multiple times the dap-ui main window gets resized to the right by a portion each time. When deactivating dap the no-neck-pain window appears correctly.
For example the first activation of dap-ui is like this on a php file:

after a couple of activation/deactivations it becaomes like this:

If I remove no-neck-pain from my setup this does not happen, so I onestly don't know which plugin causes the problem.
Many thanks

Neovim version

0.10.x

Steps to reproduce

1. open nvim with no-neck-pain
2. activate / deactivate debugging with nvim-dap-ui
3. the main dap window gets resized each time

Relevant log output

Self-service

• I'd be willing to fix this bug myself.

[shortcuts]

hey! thanks for using the plugin and reporting the issue :)

this should be fixed by #469, i'll try to finish it this evening

[shortcuts]

Hey, a proper and much better fix should be available in the new version (2.4.3), let me know if you encounter any other problem :)

[franksl]

Hi, unfortunately the problem persists with the atest version 2.4.3, if you need any information please let me know

[shortcuts]

Hey @franksl, could you please share your no-neck-pain config and nvim-dap-ui as well if possible? I'm not able to reproduce

[shortcuts]

Hey so #474 should not properly fix the issue for dap, however I have an incoming PR that should cover it

[franksl]

Hi,
Here's my pretty much standard config for no-neck-pain:

return {
    "shortcuts/no-neck-pain.nvim",
    version = "*",
    config = function (_, opts)
        require("no-neck-pain").setup({
            width = 140,
            autocmds = {
                enableOnVimEnter = true,
                skipEnteringNoNeckPainBuffer = true
            },
            buffers = {
                right = {
                    enabled = false,
                },
                wo = {
                    fillchars = "eob: ",
                }
            },
        })
    end
}

And here is my dap plugins config:

return {
    "mfussenegger/nvim-dap",
    dependencies = {
        "leoluz/nvim-dap-go",
        "rcarriga/nvim-dap-ui",
        "nvim-neotest/nvim-nio",
        "williamboman/mason.nvim",
        "theHamsta/nvim-dap-virtual-text",
        "rinx/nvim-dap-rego"
    },
    config = function (_, opts)
        local dap = require("dap")
        local dapui = require("dapui")
        dapui.setup()

        require("nvim-dap-virtual-text").setup({
        })

        -- PHP
        dap.adapters.php = {
            type = "executable",
            command = "node",
            args = { os.getenv("HOME") .. "/bin/vscode-php-debug/out/phpDebug.js" }
        }
        dap.configurations.php = {
            {
                type = "php",
                request = "launch",
                name = "Listen for Xdebug",
                port = 9003
            }
        }

        vim.keymap.set('n', '<F5>', dap.continue)
        vim.keymap.set('n', '<F10>', dap.step_over)
        vim.keymap.set('n', '<F11>', dap.step_into)
        vim.keymap.set('n', '<F12>', dap.step_out)
        vim.keymap.set('n', '<Leader>b', dap.toggle_breakpoint)

        dap.listeners.before.attach.dapui_config = function()
            dapui.open()
        end
        dap.listeners.before.launch.dapui_config = function()
            dapui.open()
        end
        dap.listeners.before.event_terminated.dapui_config = function()
            dapui.close()
        end
        dap.listeners.before.event_exited.dapui_config = function()
            dapui.close()
        end
        dap.listeners.before.disconnect.dapui_config = function()
            dapui.close()
        end
    end
}

I can confirm that v2.4.5 does not solve my problem,
Thanks