IPosition: Switch GetCoordinate() to Coordinate property#63
Open
dandeto wants to merge 1 commit intosibartlett:masterfrom
Open
IPosition: Switch GetCoordinate() to Coordinate property#63dandeto wants to merge 1 commit intosibartlett:masterfrom
dandeto wants to merge 1 commit intosibartlett:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a semantic change, so I completely understand if you don't want to accept this PR, but I adjusted the
GetCoordinate()function to be aCoordinateproperty inIPositionas a quality-of-life adjustment. For example, thePointclass already had this property and also had to implement theGetCoordinate()function to satisfy the interface. I prefer to use aCoordinateproperty rather than a function, but it's really up to the eye of the beholder if you think it's worth merging. Thanks for considering this submission!