Skip to content

Add attribution for zoom & pan animation code ported over from Recordly#260

Closed
webadderall wants to merge 4 commits intosiddharthvaddem:mainfrom
webadderall:main
Closed

Add attribution for zoom & pan animation code ported over from Recordly#260
webadderall wants to merge 4 commits intosiddharthvaddem:mainfrom
webadderall:main

Conversation

@webadderall
Copy link
Copy Markdown

@webadderall webadderall commented Apr 1, 2026

Pull Request Template

Description

Adds attribution to Recordly from animation code ported from Recordly to OpenScreen

Motivation

I only found out today that Recordly wasn't attributed for the zoom animation code, and originally, I was fine with it, but as OpenScreen grows I think the origins of the zoom animations should be set clear, especially as I spent days working on them.

I don't wish ill towards OpenScreen, just something small I wanted to set straight :)

Type of Change

  • Documentation Update

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

📝 Walkthrough

Walkthrough

Three video editor utility modules received attribution comments documenting that zoom animation, zoom region, and zoom transform logic were ported from Recordly. No functional code, imports, exports, or behavior were modified.

Changes

Cohort / File(s) Summary
Attribution Comments
src/components/video-editor/videoPlayback/mathUtils.ts, src/components/video-editor/videoPlayback/zoomRegionUtils.ts, src/components/video-editor/videoPlayback/zoomTransform.ts
Added module-level comments indicating zoom animation, zoom region, and zoom transform logic were ported from Recordly, including source attribution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit's whisper, soft and light,
Attribution shines, so clear and bright,
From Recordly's lands, the code did roam,
Now credited well, it's found a home! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The pull request description is mostly complete with a clear description, motivation, and type of change. However, it's missing some non-critical sections.
Title check ✅ Passed The title directly and clearly summarizes the main change: adding attribution comments for zoom animation code ported from Recordly across three files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@webadderall webadderall changed the title Add attribution for zoom animation code ported over from Recordly Add attribution for zoom & pan animation code ported over from Recordly Apr 1, 2026
@webadderall webadderall closed this by deleting the head repository Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants