Add attribution for zoom & pan animation code ported over from Recordly#260
Closed
webadderall wants to merge 4 commits intosiddharthvaddem:mainfrom
Closed
Add attribution for zoom & pan animation code ported over from Recordly#260webadderall wants to merge 4 commits intosiddharthvaddem:mainfrom
webadderall wants to merge 4 commits intosiddharthvaddem:mainfrom
Conversation
Agent-Logs-Url: https://github.com/webadderall/efjifieefe/sessions/e9f0375b-085a-4ff2-9c00-37032a1bf474 Co-authored-by: webadderall <131426131+webadderall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/webadderall/efjifieefe/sessions/fb010348-02e9-45a4-963a-991cc7ffe621 Co-authored-by: webadderall <131426131+webadderall@users.noreply.github.com>
…redits Remove Acknowledgements section from README
📝 WalkthroughWalkthroughThree video editor utility modules received attribution comments documenting that zoom animation, zoom region, and zoom transform logic were ported from Recordly. No functional code, imports, exports, or behavior were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds attribution to Recordly from animation code ported from Recordly to OpenScreen
Motivation
I only found out today that Recordly wasn't attributed for the zoom animation code, and originally, I was fine with it, but as OpenScreen grows I think the origins of the zoom animations should be set clear, especially as I spent days working on them.
I don't wish ill towards OpenScreen, just something small I wanted to set straight :)
Type of Change