fix: resolve bounty issue #1950 - posting tags now override inherited txn tags#2597
Open
bomlinux92-byte wants to merge 1 commit into
Open
fix: resolve bounty issue #1950 - posting tags now override inherited txn tags#2597bomlinux92-byte wants to merge 1 commit into
bomlinux92-byte wants to merge 1 commit into
Conversation
…de inherited txn tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for [BOUNTY $20] Inherited Tag Values are not Overwritten — Issue #1950
Root cause
When a posting had a tag with the same name as an inherited transaction-level tag (e.g.,
concerns: meon transaction,concerns: youon posting), the posting's tag value should overwrite the inherited one. However,postingAllTagswas doing a simple concatenation:ptags p ++ txnTags, which meant both values were retained and matched by tag queries.Fix
Modified
postingAllTagsinhledger-lib/Hledger/Data/Posting.hsto filter out transaction-level tags whose names conflict with explicitly-set posting tags:This ensures posting-level tags take precedence over inherited transaction tags with the same name, and tag queries like
tag:concerns=meonly match postings that genuinely have that effective tag value.Testing
The existing test case
a tag match on a posting also sees inherited tagsinQuery.hscontinues to pass (inherited tags without conflicts are still visible), and the fix properly handles the overwrite case.Closes #1950