Align behavior of [Camel|Pascal|Kebab|Snake]-Cased types with lodash#1394
Conversation
…nPunctuation. Update JSDoc.
…e should be with the false setting.
|
Also, please add tests for |
Ok, I'll change it so that it's in the similar pattern as the originals. The changes were very minor and aimed to increase readability of the JSDoc. I understand that here they are seen as problematic, because they are outside the ticket scope |
Yeah, the changes themselves were fine, just not in the scope of this PR. |
…nted according to pre-existing pattern.
…unctuation and number split combination.
a5b6b43 to
668146f
Compare
…ctuated user types
Added. I also updated the JSDocs for the x-cased-properties and x-cased-properties-deep types |
som-sm
left a comment
There was a problem hiding this comment.
PR LGTM, just a few minor comments. Nice work, thanks for picking this up!
WordsOptions:splitOnPunctuationoption added. Defaults tofalsefor now, so no breaking changes are introduced. Updated JSDoc for theWordstype.CamelCase, PascalCase, KebabCase, SnakeCase:splitOnPunctuationoption can be used.CamelCaseuses_DefaultWordsOptionsinstead of specifying defaults directly (this would require updates every time a new default option would be added).type NamedType1 = NamedType<Value>; //=> resultpattern.Closes #1229