Suggest yarn when installed with yarn by LitoMore · Pull Request #132 · sindresorhus/update-notifier

LitoMore · 2018-01-09T15:24:05Z

Fixes #118
Resolve #146

sindresorhus · 2018-01-10T12:21:24Z

This is not what was suggested in #118 (comment) This is not going to be accepted if it requires any fs calls. That's not worth the overhead.

nexdrew · 2018-01-10T14:54:44Z

+
+		try {
+			const realpath = fs.realpathSync(which().sync(cliName, {nothrow: true}));
+			if (realpath.match(/yarn\/global/)) {


I could be wrong, but this literal RegExp doesn't look to be Windows-friendly (hardcoded forward slash).

Perhaps we could simplify this to:

return realpath.includes(path.join('yarn', 'global'));

Thanks, I will try it in Windows.

LitoMore · 2018-01-11T04:55:13Z

@sindresorhus Thank you for your advice.

process.cwd() is a better way to get the path.

SBoudrias · 2018-01-10T01:44:04Z

 		}

 		opts = Object.assign({isGlobal: isInstalledGlobally()}, opts);
+		const installCommand = this.isYarn() ? 'yarn global upgrade ' + this.packageName : 'npm i ' + (opts.isGlobal ? '-g ' : '') + this.packageName;


We should probably do the global check on yarn too no?

We don't have to.

LitoMore · 2018-01-12T03:41:18Z

Should we create a new package is-yarn-global then require it?

sindresorhus · 2018-01-22T21:46:03Z

 		});
 	}
+	isYarnGlobal() {
+		const isWindows = process.platform === 'win32' || process.env.OSTYPE === 'cygwin' || process.env.OSTYPE === 'msys';


Should only be const isWindows = process.platform === 'win32';

sindresorhus · 2018-01-22T21:50:39Z

 			return this;
 		}

 		opts = Object.assign({isGlobal: isInstalledGlobally()}, opts);


isInstalledGlobally already supports Yarn, but it doesn't return which one it is. For that, you could use https://github.com/sindresorhus/global-dirs#packages

@sindresorhus I created a package is-yarn-global, it without any fs calls and dependencies. What about this?

LitoMore · 2018-01-23T10:58:59Z

 		}

 		opts = Object.assign({isGlobal: isInstalledGlobally()}, opts);
+		const installCommand = this.isYarnGlobal() ? 'yarn global upgrade ' + this.packageName : 'npm i ' + (opts.isGlobal ? '-g ' : '') + this.packageName;


yarn global upgrade <package> will not upgrade package to latest version. Should be yarn global add <package> or yarn global upgrade <package>@latest.

LitoMore · 2018-01-23T11:24:46Z

@sindresorhus I could be wrong, I think is-yarn-global is better than global-dirs, is-yarn-global it without any fs calls and new dependencies. Use is-yarn-global or global-dirs it's up to you.

sindresorhus · 2018-01-23T21:54:41Z

I could be wrong, I think is-yarn-global is better than global-dirs, is-yarn-global it without any fs calls and new dependencies. Use is-yarn-global or global-dirs it's up to you.

Good point, yes, go for is-yarn-global.

LitoMore · 2018-02-08T07:37:26Z

@sindresorhus is-yarn-global has been landed on this pull request, please review :)

LitoMore · 2018-06-05T11:51:59Z

@sindresorhus Code updated, please review

LitoMore · 2018-07-07T14:04:32Z

ping @SBoudrias @sindresorhus I updated my code, but the review status does not change.

Any progress with this pull request?

LitoMore · 2018-09-06T08:36:41Z

@sindresorhus Hey Sindre! Please review! Thanks!

joshmanders · 2018-10-29T20:44:51Z

Any update on this?

sindresorhus · 2019-03-28T12:00:04Z

This got lost in my review queue.

@LitoMore Can you fix the merge conflicts?

LitoMore · 2019-03-29T04:28:36Z

@sindresorhus Code updated.

sindresorhus · 2019-04-07T14:12:35Z

+			isYarnGlobal: isYarnGlobal()(),
 			...options
 		};
+		const installCommand = options.isYarnGlobal ? `yarn global add ${this.packageName}` : `npm i ${options.isGlobal ? '-g ' : ''}${this.packageName}`;


Shouldn't we also show local Yarn command?

Shouldn't we also show local Yarn command?

@sindresorhus How do we know if it is using Yarn or NPM locally?

https://github.com/sindresorhus/has-yarn

LitoMore · 2019-04-08T17:51:33Z

@sindresorhus Code updated.

bluelovers · 2019-06-01T00:16:59Z

current path is yarn project not mean this cli install by current local

should not Suggest yarn add

Suggest yarn when intalled with yarn

05f5fd5

LitoMore changed the title ~~Suggest yarn when intalled with yarn (global install)~~ Suggest yarn when installed with yarn (global install) Jan 9, 2018

nexdrew reviewed Jan 10, 2018

View reviewed changes

SBoudrias reviewed Jan 11, 2018

View reviewed changes

LitoMore added 3 commits January 11, 2018 22:41

Use process.cwd() instead

29ce070

Remove unused code

9d7f479

Remove unused dependency

6b3eb00

sindresorhus requested changes Jan 22, 2018

View reviewed changes

LitoMore commented Jan 23, 2018

View reviewed changes

Use is-yarn-global package

77238f0

Fix package name

bc85ad1

Update is-yarn-global to 0.3.0

a1b0024

sindresorhus mentioned this pull request Nov 12, 2018

Detect if the CLI has been installed globally or as a dev dependency #146

Closed

sindresorhus mentioned this pull request Jan 18, 2019

Support display specific npm client #147

Closed

LitoMore added 2 commits March 29, 2019 11:18

Merge master and fix conflict

b52ac34

Fix conflict

cbb1ed5

sindresorhus reviewed Apr 7, 2019

View reviewed changes

Merge branch 'master' into yarn-support

69b459e

Add support for local Yarn command

5352d8b

LitoMore changed the title ~~Suggest yarn when installed with yarn (global install)~~ Suggest yarn when installed with yarn Apr 8, 2019

SBoudrias reviewed May 10, 2019

View reviewed changes

Comment thread index.js Outdated

Cleanup code

a85b59f

SBoudrias merged commit ad8ed1b into sindresorhus:master May 10, 2019

LitoMore deleted the yarn-support branch May 10, 2019 08:20

BYK mentioned this pull request Apr 22, 2021

build: Move to single-file builds for craft getsentry/craft#203

Merged

huynhducduy mentioned this pull request May 30, 2022

Feat: notify users whenever an update available nvh95/jest-preview#129

Merged

1 task

Uh oh!

Conversation

LitoMore commented Jan 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sindresorhus commented Jan 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LitoMore commented Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LitoMore commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LitoMore Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LitoMore commented Jan 23, 2018

Uh oh!

sindresorhus commented Jan 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LitoMore commented Feb 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LitoMore commented Jun 5, 2018

Uh oh!

LitoMore commented Jul 7, 2018

Uh oh!

LitoMore commented Sep 6, 2018

Uh oh!

joshmanders commented Oct 29, 2018

Uh oh!

sindresorhus commented Mar 28, 2019

Uh oh!

LitoMore commented Mar 29, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LitoMore Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LitoMore commented Apr 8, 2019

Uh oh!

Uh oh!

bluelovers commented Jun 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LitoMore commented Jan 9, 2018 •

edited

Loading

LitoMore commented Jan 11, 2018 •

edited

Loading

LitoMore commented Jan 12, 2018 •

edited

Loading

LitoMore Jan 23, 2018 •

edited

Loading

sindresorhus commented Jan 23, 2018 •

edited

Loading

LitoMore commented Feb 8, 2018 •

edited

Loading

LitoMore Apr 8, 2019 •

edited

Loading