[Bug] AZURE_CREDENTIALS are in instructions but never created

[hectorsector]

Summary

A change we recently accepted removed the creation of a secret called AZURE_CREDENTIALS. That secret is still utilized in one of the workflows we ask the learner to create:

deploy-to-azure/.github/steps/3-spinup-environment.md

Lines 64 to 67 in ae0c3ff

	- name: Azure login
	uses: azure/login@v2
	with:
	creds: ${{ secrets.AZURE_CREDENTIALS }}

How to reproduce

1. Take the course
2. At step 3, you'll see the workflow referenced. It will immediately fail on the login action.
3. The course will continue to move forward eventually, but no actual Azure workflow ran.

[bronthulke]

Yep I've just experienced the same issue.

For those who are struggling to get past this, this is what I did:

1. Delete the service principal created previously and recreate it, but this time in the CLI include the argument --json-auth
2. Add an Actions Secret in GitHub for AZURE_CREDENTIALS with the JSON returned from the above
3. Update the existing secrets created for AZURE_TENANT_ID and AZURE_CLIENT_ID with the values out of JSON
4. Go to Actions and into the failed run, and click "Rerun all jobs" (it will skill skip the Destroy job)

This worked for me, and then I was able to continue with the exercise.

I also continued to have issues with the deploy-staging.yml file, as that was set up to use the client ID, tenant ID and subscription ID for login auth and this had issues. I ended up changing that one to use the AZURE_CREDENTIALS as well.