refactor: rewrite the exercise with issue based flow#108
Merged
FidelusAleksander merged 16 commits intoskills:mainfrom Jan 28, 2026
Merged
refactor: rewrite the exercise with issue based flow#108FidelusAleksander merged 16 commits intoskills:mainfrom
FidelusAleksander merged 16 commits intoskills:mainfrom
Conversation
- Updated template_owner parameter in README.md badge URL from skills-dev to skills
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a GitHub Skills exercise repository from the skills-dev to skills organization, modernizes the exercise structure, and significantly enhances the Tic Tac Toe game used in the exercise. The changes include workflow modernization using the exercise-toolkit framework, comprehensive documentation updates, and functional improvements to the game implementation.
Changes:
- Migrated organization references from skills-dev to skills and updated copyright to 2025
- Completely rewrote workflow files to use the new exercise-toolkit framework (v0.5.0)
- Enhanced the Tic Tac Toe game with draw detection, a "Play again" button, and differentiated win/loss/draw messages
- Modernized step-by-step exercise content with improved explanations and clearer instructions
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| index.html | Added draw detection logic, "Play again" button with reload functionality, and dynamic game over messages for different outcomes |
| README.md | Updated organization references to skills, modernized exercise introduction, replaced course terminology with exercise, and updated copyright year to 2025 |
| .github/workflows/*.yml | Deleted old workflow files and added new exercise-toolkit-based workflows for each step with consistent structure |
| .github/steps/*.md | Removed old step markdown files and added new comprehensive step guides with improved explanations and detailed instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly rewrites and restructures the step-by-step instructional content for a GitHub Skills exercise on reviewing pull requests. The updates modernize the language, clarify instructions, and introduce a more engaging and user-friendly format. Several new step files are added, old ones are removed, and the workflow is updated for a smoother learner experience.
The most important changes include:
Instructional Content Rewrite and Restructuring:
Rewrote and reorganized all instructional markdown files for each step of the exercise (
1-step.md,2-step.md,3-step.md,4-step.md,5-step.md,6-merge-your-pull-request.md,x-review.md), replacing the previous versions to provide clearer, more concise, and more engaging guidance. This includes improved explanations, updated activity instructions, and more context on GitHub features. [1] [2] [3] [4] [5] F483bc79R1)Removed outdated instructional files and author notes, such as
1-open-a-pull-request.md,2-assign-yourself.md,3-leave-a-review.md,4-suggest-changes.md,5-apply-changes.md, and6-merge-your-pull-request.md, to eliminate redundancy and confusion. [1] [2] [3] [4] [5] [6]Workflow Improvements:
.github/workflows/0-start-exercise.ymlto automate the initial exercise setup, including branch creation, updatingindex.html, committing changes, and posting step instructions to the learner. This streamlines the onboarding process for users starting the course.Finishing Touches and Next Steps:
X-finish.mdtox-review.md) to better summarize the learner's accomplishments and provide updated links for further learning and feedback.Minor Cleanups:
.github/steps/-step.txtand.github/steps/0-welcome.mdfor a cleaner repository structure. [1] [2]