Skip to content

refactor: rewrite the exercise with issue based flow#108

Merged
FidelusAleksander merged 16 commits intoskills:mainfrom
skills-dev:skills-update
Jan 28, 2026
Merged

refactor: rewrite the exercise with issue based flow#108
FidelusAleksander merged 16 commits intoskills:mainfrom
skills-dev:skills-update

Conversation

@FidelusAleksander
Copy link
Copy Markdown
Contributor

@FidelusAleksander FidelusAleksander commented Jan 27, 2026

This pull request significantly rewrites and restructures the step-by-step instructional content for a GitHub Skills exercise on reviewing pull requests. The updates modernize the language, clarify instructions, and introduce a more engaging and user-friendly format. Several new step files are added, old ones are removed, and the workflow is updated for a smoother learner experience.

The most important changes include:

Instructional Content Rewrite and Restructuring:

  • Rewrote and reorganized all instructional markdown files for each step of the exercise (1-step.md, 2-step.md, 3-step.md, 4-step.md, 5-step.md, 6-merge-your-pull-request.md, x-review.md), replacing the previous versions to provide clearer, more concise, and more engaging guidance. This includes improved explanations, updated activity instructions, and more context on GitHub features. [1] [2] [3] [4] [5] F483bc79R1)

  • Removed outdated instructional files and author notes, such as 1-open-a-pull-request.md, 2-assign-yourself.md, 3-leave-a-review.md, 4-suggest-changes.md, 5-apply-changes.md, and 6-merge-your-pull-request.md, to eliminate redundancy and confusion. [1] [2] [3] [4] [5] [6]

Workflow Improvements:

  • Added a new workflow file .github/workflows/0-start-exercise.yml to automate the initial exercise setup, including branch creation, updating index.html, committing changes, and posting step instructions to the learner. This streamlines the onboarding process for users starting the course.

Finishing Touches and Next Steps:

  • Updated the final step file (renamed from X-finish.md to x-review.md) to better summarize the learner's accomplishments and provide updated links for further learning and feedback.

Minor Cleanups:

  • Removed unused or placeholder files such as .github/steps/-step.txt and .github/steps/0-welcome.md for a cleaner repository structure. [1] [2]

Copilot AI review requested due to automatic review settings January 27, 2026 12:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a GitHub Skills exercise repository from the skills-dev to skills organization, modernizes the exercise structure, and significantly enhances the Tic Tac Toe game used in the exercise. The changes include workflow modernization using the exercise-toolkit framework, comprehensive documentation updates, and functional improvements to the game implementation.

Changes:

  • Migrated organization references from skills-dev to skills and updated copyright to 2025
  • Completely rewrote workflow files to use the new exercise-toolkit framework (v0.5.0)
  • Enhanced the Tic Tac Toe game with draw detection, a "Play again" button, and differentiated win/loss/draw messages
  • Modernized step-by-step exercise content with improved explanations and clearer instructions

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.

File Description
index.html Added draw detection logic, "Play again" button with reload functionality, and dynamic game over messages for different outcomes
README.md Updated organization references to skills, modernized exercise introduction, replaced course terminology with exercise, and updated copyright year to 2025
.github/workflows/*.yml Deleted old workflow files and added new exercise-toolkit-based workflows for each step with consistent structure
.github/steps/*.md Removed old step markdown files and added new comprehensive step guides with improved explanations and detailed instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread .github/steps/4-step.md
@FidelusAleksander FidelusAleksander changed the title Update with all changes from skills-dev fork refactor: rewrite the exercise with issue based flow Jan 28, 2026
@FidelusAleksander FidelusAleksander merged commit 9d4440e into skills:main Jan 28, 2026
8 of 10 checks passed
@FidelusAleksander FidelusAleksander deleted the skills-update branch January 28, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants