add a SumEvt function#188
Open
silkenelson wants to merge 1 commit intomasterfrom
Open
Conversation
…avoids a potentially wasteful copy operation needed for chaining functions)
Collaborator
|
I think it would be better to sub-class the existing ROIFunc and only rewrite the process method. This way we dont duplicate the setFromDet and applyROI, and in case we need to change them (unlikely) we only have to do it in one spot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we only want the calculation for the ROI having a specific function avoids a potentially wasteful copy operation needed for chaining functions.
This is a best we can easily do for https://jira.slac.stanford.edu/browse/ECS-4440