ENH Map pixel indices to physical coordinates pyFAI detector#274
ENH Map pixel indices to physical coordinates pyFAI detector#274LouConreux wants to merge 3 commits intoslac-lcls:masterfrom
Conversation
… detector object, rather than at every event assembling the image
|
The code change itself looks fine to me, but the path issues are what need to be resolved - and this repo itself is probably not the place where we can make that decision. Regardless of the ultimate decision, I don't think we should do the path manipulation to make this available - it will be very brittle. Some options - number 1 is by far the easiest for many use cases:
|
|
It was not really an issue, I just realized I needed to clean the code before adding LCLSGeom to the environment. |
|
Yup I agree - if it can be added to the environment it should be 👍 Just with regards to this PR it should be added before merging so the path modifications can be taken out |
Description
This PR aims at improving the pyFAI azimuthal integration script. Rather than assembling the images at each event, we define a mapping between pixel and physical space only once through the use of LCLSGeom creating a pyFAI detector object with pixel coordinates. This discards the need for casting 3D images into hard-coded 2D assembled images.
Checklist
LCLSGeomto path/environment (see Address Issues)smalldata_tools/ana_funcs/azav_pyfai.pyPR Type
Address Issues
LCLSGeomat top of scriptLUTE?Test on LCLS-II detectors
Test was done through
luteonmfx101343025run 8 at/sdf/data/lcls/ds/mfx/mfx101343025/results/lconreux/launchpad/pyfai_ENHfor logs.Command run:
/sdf/data/lcls/ds/mfx/mfx101343025/results/lconreux/lute/install/bin/activate_installationsubmit_slurm -t SmallDataProducer2 -c /sdf/data/lcls/ds/mfx/mfx101343025/results/lconreux/yamls/smd_pyfai_config_1.yaml -e mfx101343025 -r 8 --psana2 --partition=milano --account=lcls:prjlute22 --nodes=8 --ntasks-per-node=50 --exclusive/sdf/data/lcls/ds/mfx/mfx101343025/results/lconreux/launchpad/pyfai_ENH/SmallDataProducer2Test_mfx101343025_r0008_2026-03-11_18-27-45_23131031.out: