Closed
Conversation
This commit temporarily pins crc-fast to 1.4 to prove that the new architecture tests would have caught the illegal instruction fault on ARM before merge. This will be reverted after CI demonstrates the failure.
3 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
vcjana
force-pushed
the
test-crc-fast-1.4
branch
from
09b57b7 to
1e7018f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Use =1.4.0 instead of 1.4 to ensure Cargo uses exactly version 1.4.0 (the version with the ARM SIGILL bug) rather than allowing semver compatible updates to newer fixed versions. This addresses review feedback from landonxjames.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
- Change runs-on from ubuntu-latest to ubuntu-24.04-arm for ARM targets - Use native cargo test instead of cross for actual ARM execution - This will catch crc-fast 1.4 SIGILL on GitHub's ARM runners
- Add architectures parameter to generate_matrix.rs - Create canary-scheduled.yml workflow with 4-arch matrix - Test x86_64-gnu, x86_64-musl, aarch64-gnu, aarch64-musl - Use native ARM runners for actual runtime testing - Run daily to catch dependency issues like crc-fast 1.4 This would have caught the crc-fast 1.4 SIGILL issue that was missed in smithy-rs CI but caught in aws-sdk-rust canary.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This was referenced Dec 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR temporarily pins crc-fast to 1.4 to demonstrate that the architecture testing added in #4428 would have caught the ARM SIGILL issue before merge.
Context
Expected Result
The
test-runtime-architecturesjob should fail on ARM targets (aarch64-unknown-linux-gnu, aarch64-unknown-linux-musl) with SIGILL, proving that PR #4428's architecture testing would have prevented this issue.Note
This PR should NOT be merged. It exists only to demonstrate the test coverage gap. Once CI shows the ARM failures, this proves #4428's value and this PR can be closed.
Related: #4428